Browse Source

[Credo][CI] Add readability as it’s fixed

stable
Haelwenn (lanodan) Monnier 3 years ago
parent
commit
4b73ca638e
No known key found for this signature in database GPG Key ID: D5B7A8E43C997DEE
  1. 4
      .credo.exs
  2. 2
      .gitlab-ci.yml
  3. 1
      lib/mix/tasks/pleroma/uploads.ex
  4. 1
      lib/pleroma/uploaders/uploader.ex
  5. 1
      lib/pleroma/web/nodeinfo/nodeinfo.ex

4
.credo.exs

@ -81,7 +81,9 @@
{Credo.Check.Readability.ParenthesesOnZeroArityDefs},
{Credo.Check.Readability.ParenthesesInCondition},
{Credo.Check.Readability.PredicateFunctionNames},
{Credo.Check.Readability.PreferImplicitTry},
# lanodan: I think PreferImplicitTry should be consistency, and the behaviour seems
# inconsistent, see: https://github.com/rrrene/credo/issues/224
{Credo.Check.Readability.PreferImplicitTry, false},
{Credo.Check.Readability.RedundantBlankLines},
{Credo.Check.Readability.StringSigils},
{Credo.Check.Readability.TrailingBlankLine},

2
.gitlab-ci.yml

@ -42,4 +42,4 @@ unit-testing:
analysis:
stage: analysis
script:
- mix credo list --only=warnings,todo,fixme,consistency
- mix credo list --only=warnings,todo,fixme,consistency,readability

1
lib/mix/tasks/pleroma/uploads.ex

@ -20,7 +20,6 @@ defmodule Mix.Tasks.Pleroma.Uploads do
Options:
- `--delete` - delete local uploads after migrating them to the target uploader
A list of available uploaders can be seen in config.exs
"""
def run(["migrate_local", target_uploader | args]) do

1
lib/pleroma/uploaders/uploader.ex

@ -29,7 +29,6 @@ defmodule Pleroma.Uploaders.Uploader do
* `{:error, String.t}` error information if the file failed to be saved to the backend.
* `:wait_callback` will wait for an http post request at `/api/pleroma/upload_callback/:upload_path` and call the uploader's `http_callback/3` method.
"""
@type file_spec :: {:file | :url, String.t()}
@callback put_file(Pleroma.Upload.t()) ::

1
lib/pleroma/web/nodeinfo/nodeinfo.ex

@ -1 +0,0 @@
Loading…
Cancel
Save