Browse Source

[Credo][CI] Add readability as it’s fixed

stable
Haelwenn (lanodan) Monnier 2 years ago
parent
commit
4b73ca638e
No known key found for this signature in database GPG Key ID: D5B7A8E43C997DEE
5 changed files with 4 additions and 5 deletions
  1. +3
    -1
      .credo.exs
  2. +1
    -1
      .gitlab-ci.yml
  3. +0
    -1
      lib/mix/tasks/pleroma/uploads.ex
  4. +0
    -1
      lib/pleroma/uploaders/uploader.ex
  5. +0
    -1
      lib/pleroma/web/nodeinfo/nodeinfo.ex

+ 3
- 1
.credo.exs View File

@ -81,7 +81,9 @@
{Credo.Check.Readability.ParenthesesOnZeroArityDefs},
{Credo.Check.Readability.ParenthesesInCondition},
{Credo.Check.Readability.PredicateFunctionNames},
{Credo.Check.Readability.PreferImplicitTry},
# lanodan: I think PreferImplicitTry should be consistency, and the behaviour seems
# inconsistent, see: https://github.com/rrrene/credo/issues/224
{Credo.Check.Readability.PreferImplicitTry, false},
{Credo.Check.Readability.RedundantBlankLines},
{Credo.Check.Readability.StringSigils},
{Credo.Check.Readability.TrailingBlankLine},


+ 1
- 1
.gitlab-ci.yml View File

@ -42,4 +42,4 @@ unit-testing:
analysis:
stage: analysis
script:
- mix credo list --only=warnings,todo,fixme,consistency
- mix credo list --only=warnings,todo,fixme,consistency,readability

+ 0
- 1
lib/mix/tasks/pleroma/uploads.ex View File

@ -20,7 +20,6 @@ defmodule Mix.Tasks.Pleroma.Uploads do
Options:
- `--delete` - delete local uploads after migrating them to the target uploader
A list of available uploaders can be seen in config.exs
"""
def run(["migrate_local", target_uploader | args]) do


+ 0
- 1
lib/pleroma/uploaders/uploader.ex View File

@ -29,7 +29,6 @@ defmodule Pleroma.Uploaders.Uploader do
* `{:error, String.t}` error information if the file failed to be saved to the backend.
* `:wait_callback` will wait for an http post request at `/api/pleroma/upload_callback/:upload_path` and call the uploader's `http_callback/3` method.
"""
@type file_spec :: {:file | :url, String.t()}
@callback put_file(Pleroma.Upload.t()) ::


+ 0
- 1
lib/pleroma/web/nodeinfo/nodeinfo.ex View File

@ -1 +0,0 @@

Loading…
Cancel
Save